Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(performance): ACT-1219 performance optimisations #109

Merged
merged 11 commits into from
Jan 2, 2025

Conversation

Jarvv
Copy link
Contributor

@Jarvv Jarvv commented Dec 19, 2024

Ticket: https://ready-player-me.atlassian.net/jira/software/c/projects/ACT/boards/46?selectedIssue=ACT-1219

Recommendations for integration optimisation:

  • Keep canvas size at a limited width, especially important at 4k screens. If we don't need to show the full canvas, then the canvas size can be adjusted to fit around the avatar. Taking into account attachments such as wings, or zooming in/out
  • Base DPR could be < 1, lower values greatly reduce gpu load however this should be balanced with visual fidelity. Perhaps these values should be higher in 'editors' rather than just 'viewers' for instance.

Example with PlayerZero:
before:
Screenshot 2024-12-19 161418

after:
Screenshot 2024-12-19 163246
Screenshot 2024-12-19 163706

by setting the canvas size appropriately (this will be too much but as an example), we can easily reduce GPU usage by 4%.

src/App/components/Develop.tsx Outdated Show resolved Hide resolved
@Jarvv Jarvv marked this pull request as ready for review December 19, 2024 16:54
@Jarvv Jarvv requested a review from a team as a code owner December 19, 2024 16:54
@Jarvv Jarvv merged commit f79b40f into main Jan 2, 2025
3 checks passed
@Jarvv Jarvv deleted the ACT-1219-performance-optimisations branch January 2, 2025 16:38
Copy link

github-actions bot commented Jan 2, 2025

🎉 This PR is included in version 6.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants